#98 ✓resolved
Alex "Alexspeed" Bachner

"DAModder installs EVERYTHING"-Issue

Reported by Alex "Alexspeed" Bachner | December 14th, 2009 @ 07:32 AM | in Beta 3

this is from Beta 2.2.0

right now you can drag everything onto the Application tab and DAModder tries to install it.
I am not sure this is really an issue or if this can be resolved.
Is there a way to check for DAModder if its really a mod that was dragged onto the window to install?

i made several tests:

  • dragged a .txt in a folder onto damodder, it tries to install it
  • dragged a empty folder onto damodder, nothing happens (thats working as intended)
  • dragged a .zip with a .txt onto damodder, it tries to install it
  • with other stuff you can get funny results ^^

like i dragged a .jpg onto the damodder window -> it adds the image to the infowindow and freezes -> see pic damodder_14.jpg that i added

with a shortcut it freezes too, if the shortcut leads to an executable it tries to execute it and you get a popup warning -> see pic damodder_15.jpg that i added

with a text file it adds the content of the textfile to the infowindow and freezes, i made no pic of that, you get the idea.

i didnt tried more than that.

Comments and changes to this ticket

  • John Vanderbeck

    John Vanderbeck December 14th, 2009 @ 09:22 AM

    • Tag changed from “modinstall, suggestion, ui” to “blocker, modinstall, suggestion, ui”
    • Milestone set to “Beta 3”

    Yikes.

  • John Vanderbeck

    John Vanderbeck December 14th, 2009 @ 09:37 AM

    • State changed from “new” to “resolved”

    (from [107]) - fixed bug in pre-install check that would allow DAModder to try and install anything at all. This resolves ticket #98 [#98 state:resolved]

  • Alex "Alexspeed" Bachner

    Alex "Alexspeed" Bachner December 14th, 2009 @ 03:18 PM

    This is quasi-resolved, this still can be done:

    dragged a .txt in a folder onto damodder, it tries to install it

    dragged a .zip with a .txt onto damodder, it tries to install it

    I guess there is nothing that can be done to check if its really a mod or just an txt file?

  • Alex "Alexspeed" Bachner

    Alex "Alexspeed" Bachner December 14th, 2009 @ 05:10 PM

    not sure why the text above is showing up so big, that was unintended.

  • John Vanderbeck

    John Vanderbeck December 14th, 2009 @ 05:21 PM

    Yeah if its a folder or a zip, it really just assumes it has valid mod data in it. I mean I could specifically look to see if its just a txt file, but then what if its a txt and a jpg, or 2 text files -- you start getting into infinite possibilities :) At some point I have to just assume your trying to install a mod. At least the obvious security issues have been resolved -- it won't execute anything anymore. It just does its copying of files.

  • Alex "Alexspeed" Bachner

    Alex "Alexspeed" Bachner December 14th, 2009 @ 05:24 PM

    okay i guess thats fair enough then, thanks =)

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

DAModder is a full featured replacement for Bioware's DAUpdater program -- with more features!

People watching this ticket

Attachments

Tags

Referenced by

Pages